acekhoon / pe

0 stars 0 forks source link

UML Diagram for Model Class does not specify how many "phone", "name", "address", and "email" attributes that a person could possess. #11

Open acekhoon opened 2 months ago

acekhoon commented 2 months ago

In the UML diagram of model class from Developer Guide, even though one person could possess one and only one phone number, name, address and email, they are not specified with the value "1" on the arrow pointing to those attributes from the person class.

Screenshot 2024-04-19 at 5.16.37 PM.png

nus-se-script commented 2 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

UML diagram is inaccurate to the app implementation

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.


image.png

Person to CCA is missing a composite relation.


[original: nus-cs2103-AY2324S2/pe-interim#652] [original labels: severity.Low type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Valid.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: This issue is not pointing out that composition relation between Person and CCA is missing. The issue is that, even though Person class needs to contain only and only one Phone, Name, Address and Email attributes, they did not indicate on the arrow indicating composition relation that only 1 of them are allowed (i.e. there should be 1 above the composition arrow from Person to Phone, Name, Address and Email classes).


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.VeryLow`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]