acekhoon / pe

0 stars 0 forks source link

Inconsistency between UML diagram of Model class and UML diagram for OOP design for Person class below #12

Open acekhoon opened 2 months ago

acekhoon commented 2 months ago

In the main UML diagram of the model class, Person class does not contain Role as an attribute. However, the UML diagram below shows that addressbook contains UniqueRoleList as an attribute with Person class having reference to any number of Roles. As a developer, I feel that this might be a bit confusing since the developer would not be sure which UML diagram is correct (i.e. developer would not be sure whether addressbook contains uniquerolelist, and whether person contains role due to the discrepancy bewteen two diagrams). THe main model UML could add these extra classes.

Screenshot 2024-04-19 at 5.16.37 PM.png

Screenshot 2024-04-19 at 5.29.26 PM.png

nus-pe-script commented 2 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

UML diagram is inaccurate to the app implementation

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.


image.png

Person to CCA is missing a composite relation.


[original: nus-cs2103-AY2324S2/pe-interim#652] [original labels: severity.Low type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Valid.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]