acekhoon / pe

0 stars 0 forks source link

Assign method adds a new role simultaneously onto every CCA associated to that person (There is no method to assign different rols to different CCAs that individual is taking part of) #7

Open acekhoon opened 2 months ago

acekhoon commented 2 months ago

Description: assign method is indeed one of the key features for this product, but it does not allows assigning different roles to "individual" CCA members. In fact, I could not find any way to assign different roles to 1 member where that member is enrolled in different CCAs. This is because, edit method removes the roles and CCAs entirely, and it adds the new role to every CCA provided. For instance, if the command is "edit 8 r/A r/B c/CCA1 c/CCA2", the edit method adds role named "A" and "B" to both CCA1 and CCA2, not separately. If the user wants to assign role "A" to "CCA1" and role "B" to "CCA2", neither assign method nor edit method are allowed to perform this function, which I believe is one of the most crucial feature that the product must provide to the users.

Separately from the above description of the feature flaw, here is a step to reproduce on the fact that assign cannot assign different role to 2 different CCAs for one individual member:

Steps to reproduce:

Prerequisite: There must be at least a person enrolled in more than 1 CCAs.

Typed in the command "assign 8 r/A r/B c/NUS Cycling c/NUS Origami"

Expected: (Maybe A is added to NUS Cycling, B is added to NUS Origami)

Actual:

Screenshot 2024-04-19 at 5.07.46 PM.png

Screenshot 2024-04-19 at 5.08.47 PM.png

soc-se-bot commented 2 months ago

Team's Response

No details provided by team.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: First of all, developer team did not provide any valid reason for rejecting the bug provided above, which disables me to evaluate the bug I suggested in the PE testing phase. The issue I raised in this case is that there is a key feature missing where there is no valid method or functions in this product to assign different roles to different CCA for each person in the list. For instance, if I want to assign a role of President at NUS Cycling and a role of Treasurer at NUS Math Soc for person at 1st entry in the list, there is no possible method provided to allow this operation. However, in most of the cases, it is possible and, in fact, common to find that a single person is enrolled in CCA with different positions (e.g. I am enrolled in NUS Invest as Director and NUS Math Soc as Treasurer).

As descried above, assign method assigns the same role simultaneously to every CCA that a member is enrolled in (e.g. assign 8 r/Treasurer c/NUS Cycling c/NUS Math Soc, then both nus cycling and nus math soc will assign the person at the 8th position to the position treasurer), and edit method also does the same thing where it does not allow assigning differernt roles to different CCAs that a single member is enrolled in. Overall, none of the commands in this product support the abovementioned operations, which I believe that it is one of the most important feature that needs to be supported by the product to make this product useful to the target users specified.

Therefore, with the above reason described, I believe that this is a feature flaw where important key feature is not supported by the product, thus objecting the response from developer team.


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** With the rational described in the issue response above, I think this is a key feature missing from this product where the product does not have a feature to assign different roles to different CCAs for each member since each single member could take different positions in different CCAs. Thus, I awarded a severity medium since this is one of the key features (or edge case) that I think is crucial for making this product useful to the users.