chore: set revalidate to false

kaf-lamed-beyt commented 6 months ago

What does this PR do?

Fixes #315

@acekyd, I noticed that this issue was our own doing. I had to inspect the page in pro, and it refreshes every 5000ms, which was what we've asked it to do, literally.

I wondered why it worked formerly — no refreshes when it was formerly 3000ms. The only hypothesis I have now is because the former implementation wasn't extending React's cache. Now that the request in the hook is memoized, there's no need for the revalidation, I guess.

Eventually, I had to set revalidate to false.

This PR [Fixes #315

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] Chore (refactoring code, technical debt, workflow improvements)
[ ] Enhancement (small improvements)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How should this be tested?

You can check this version I deployed on netlify

Checklist

Required

[x] Filled out the "How to test" section in this PR
[x] Self-reviewed my own code
[ ] Commented on my code in hard-to-understand bits
[ ] Ran npm run build
[ ] Checked for warnings, there are none
[ ] Removed all console.logs
[ ] Merged the latest changes from main onto my branch with git pull origin main
[ ] My changes don't cause any responsiveness issues

Appreciated

[ ] If a UI change was made: Added a screen recording or screenshots to this PR
[ ] Updated the Docs if changes were necessary

codesandbox[bot] commented 6 months ago

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders
Open Preview

netlify[bot] commented 6 months ago

Deploy Preview for made-in-nigeria-dev processing.

Name	Link
Latest commit	18bbbb6ca5def927c9e7c674e9e02caf8d65ef26
Latest deploy log	https://app.netlify.com/sites/made-in-nigeria-dev/deploys/661ed3ceb942050008a970cf

acekyd commented 6 months ago

Loool are you joking? @kaf-lamed-beyt 😂 Checking it out

kaf-lamed-beyt commented 6 months ago

I don't even know😂. The cache explanation is just assumption.

But, I'm pretty sure the revalidate property is definitely what's causing the refresh.

kaf-lamed-beyt commented 6 months ago

It does seem to fix it. Do you know how we should reset the cache when new projects are added to the readme then, or that should reset on build?

I think the build should reset the cache.

If there's a way to identify the cache with a key, it would have made it easier for us to reset it manually.

I don't know if it is possible with the cache module from React. But, I'll check and let you know when I find something.

acekyd / made-in-nigeria