search

acelaya / doctrine-enum-type

A custom Doctrine type that maps column values to enum objects using myclabs/php-enum
MIT License
132 stars 15 forks source link

Fix docblock #12

Closed ossinkine closed 6 years ago

ossinkine commented 6 years ago

PHPStan alerts second parameter should always be null

acelaya commented 6 years ago

PHPstan is now failing. I think you should just remove the null in the doc (it was probably added by my IDE), instead of adding the string type hints.

Future versions of this package will suport PHP 7.X only, fixing this problem.

ossinkine commented 6 years ago

@acelaya PHPStan failure is not related to this PR

acelaya commented 6 years ago

Right. Then I'll try to fix it so that you can rebase

acelaya commented 6 years ago

The problem was caused because I was installing phpstan without version. It fails with the latest one.

I'm fixing it and pushing it to master.

acelaya commented 6 years ago

It's up now. You can rebase.

acelaya commented 6 years ago

Just realized I have had to fix this. Thanks anyway :-)