Artillerytables - Fix `Low` shots & bad params

acemod / ACE3

Open-source realism mod for Arma 3

https://ace3.acemod.org

Other

1.01k stars 737 forks source link

Artillerytables - Fix `Low` shots & bad params #10325

Closed johnb432 closed 2 months ago

johnb432 commented 2 months ago

When merged this pull request will:

Fixes #10321.
Fixes bad parameters being passed.

I didn't test how the bad params affected gameplay.

IMPORTANT

If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
Development Guidelines are read, understood and applied.
Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

johnb432 commented 2 months ago

I forgot to update the extensions in the repository, but I'm not 100 % certain how to go about that.

PabstMirror commented 2 months ago

cargo make release u may have to install it first https://github.com/sagiegurari/cargo-make?tab=readme-ov-file#installation if you use vscode, you can grab the https://github.com/acemod/ACE3/tree/master/tools/.vscode and it will show under tasks

johnb432 commented 2 months ago

cargo make release u may have to install it first https://github.com/sagiegurari/cargo-make?tab=readme-ov-file#installation if you use vscode, you can grab the https://github.com/acemod/ACE3/tree/master/tools/.vscode and it will show under tasks

I managed to build the extension locally for testing, but I didn't quite understand which arguments to use. Thanks for the enlightenment, I believe to have understood it now.