Arsenal - Make ACE_asItem and ACE_isUnique apply to CfgWeapons

[DartRuffian]

When merged this pull request will:

• Title. Use-case is for updating items from other mods to not act as mine detectors and still show in the ACE Arsenal.
  • Updating their simulation / type alone makes them work correctly, but they don't show as misc items since they do not inherit from CBA_MiscItem.

IMPORTANT

• If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
• Development Guidelines are read, understood and applied.
• Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

[DartRuffian]

Seems like some part of this breaks painkillers, as they no longer appear in the arsenal in either the medical tab or misc items tab. I'll take another look in the morning

[DartRuffian]

Realized I should denote it here, but Grim might have had a different idea, and that I should remind him when 3.18.1 is being looked at

[DartRuffian]

Validate reports missing ; on Line 163, but it runs fine

161 {
162     _magazineMiscItems set [configName _x, nil];
163 } forEach (toString {_x call FUNC(isMiscItem)} configClasses _cfgMagazines);

[LinkIsGrim]

It's because of the code block. It's fine and the ; will actually make it not work

[PabstMirror]

it's Run python3 tools/sqf_validator.py not hemtt

[LinkIsGrim]

Reading is hard

[DartRuffian]

Just FYI, this means magazines will be slower.

Thought about this, maybe optional param for config for the item? I.e.

["someMag", configFile >> "CfgMagazines"] call ace_arsenal_fnc_isMiscItem;

Saves the call to getItemConfig. It also would get around potentially getting the wrong config path back if there's same class names in different root classes

[LinkIsGrim]

Just FYI, this means magazines will be slower.

Thought about this, maybe optional param for config for the item? I.e.

["someMag", configFile >> "CfgMagazines"] call ace_arsenal_fnc_isMiscItem;

Saves the call to getItemConfig. It also would get around potentially getting the wrong config path back if there's same class names in different root classes

Optimize for string and cache it, we make enough lookups for it to be worth it anyway. I have that ready as soon as I can fix magazine misc items

[DartRuffian]

I might mess with it later tonight, no guarantee though

[LinkIsGrim]

https://github.com/acemod/ACE3/tree/pr/10366/cache moved everything to do with misc items to that function Things to test:

• [x] Mine detector still shows up
• [x] FAKs, Medkits, and toolkits still show up and get sorted properly (need to test with and without medical)
• [x] Painkillers & spare barrels still show up and get sorted properly
• [x] Intel Items still show up when picked up but aren't available in a full arsenal

Besides intel items, all need to be tested in an arsenal where they should be available (VR mission is fine) and one where they shouldn't

[DartRuffian]

I'll test tonight. I'll test the same things you had listed previously as well as an item that originally inherited from ItemCore and then had its type/simulation changed

[DartRuffian]

• [x] Mine detector still shows up
• [x] FAKs, Medkits, and toolkits still show up and get sorted properly (need to test with and without medical)
  • [x] With ACE Medical
  • [ ] Without ACE Medical
• [x] Painkillers & spare barrels still show up and get sorted properly
• [x] Intel Items still show up when picked up but aren't available in a full arsenal
  • Not familiar with the intel items, but acex_intelitems_notepad does appear in Tools
• [x] ItemCore child class with modified type/simulation
  • In case it's relevant, I used ACE 3 Extension (Placeables) to test.

[DartRuffian]

Test Mission with two arsenals. One full and one limited (there are placed comments with details) Misc%20Item%20Test.VR.zip

[LinkIsGrim]

Not familiar with the intel items, but acex_intelitems_notepad does appear in Tools

Open Zeus, go to props/empty side units, search for intel > place a document/photo

[LinkIsGrim]

More tests:

• [ ] Check if uniforms/vests/backpacks inside inventory still show up
• [ ] Check if weapons & attachments inside inventory still show up
• [ ] Check if belt items (GPS, Radio, Map, Watch) inside inventory still show up
• [ ] Check if goggles & NVGs inside inventory still show up

These could be in a test script if we cared enough (at least we can check if they're sorted into the right buckets, interface would still need manual checking) I guess @johnb432 ?

[DartRuffian]

Open Zeus, go to props/empty side units, search for intel > place a document/photo

Done, I have a acex_intelitems_document in my inventory and it says I have 0 in the arsenal. I assume that's the intended outcome for intel items?

[DartRuffian]

• [x] Check if uniforms/vests/backpacks inside inventory still show up
• [x] Check if weapons & attachments inside inventory still show up
• [x] Check if belt items (GPS, Radio, Map, Watch) inside inventory still show up
• [x] Check if goggles & NVGs inside inventory still show up

Never even knew ACE handled these, TIL. Only issue I found was that the Chemical Detectors are showing under Bipods.

[LinkIsGrim]

Never even knew ACE handled these, TIL. Only issue I found was that the Chemical Detectors are showing under Bipods.

They fall into the category of items this PR was made for, which is non-CBA, non-special, CfgWeapons misc items. Adding ACE_asItem to them should sort them correctly.

[DartRuffian]

I'll add it to those classes then. Should they be modified in arsenal itself or another addon?

I assume arsenal, but figured I'd check beforehand.

[DartRuffian]

@LinkIsGrim

[LinkIsGrim]

Arsenal

[LinkIsGrim]

inb4 "the chemical detector you guys added doesn't do anything"