acemod / ACE3

Open-source realism mod for Arma 3
https://ace3.acemod.org
Other
1.01k stars 737 forks source link

Aegis Compat - Add realistic names for basegame variants #10370

Closed rekterakathom closed 1 month ago

rekterakathom commented 1 month ago

When merged this pull request will:

Aegis SPAR-16 could reference the realisticnames stringtable instead of being "duplicated", but I've done it this way in case either one should be changed in the future. Issue opening pending to discuss the naming of the SPAR-16s in the realisticnames addon.

Edit: Link to naming discussion

IMPORTANT

johnb432 commented 1 month ago

Aegis SPAR-16 could reference the realisticnames stringtable instead of being "duplicated", but I've done it this way in case either one should be changed in the future. Issue opening pending to discuss the naming of the SPAR-16s in the realisticnames addon.

Imo not a good reason: If something changes in the future, you have to redo all translations either way.

rekterakathom commented 1 month ago

Formatting fixed, changed the SPAR-16 to use the realisticnames stringtable to avoid duplication

johnb432 commented 1 month ago

Add realistic names to all Aegis primary weapons

Currently, this only renames weapons that are part of the basegame, it doesn't affect any of the weapons that the mods adds (e.g. AK-103, AK-12, AK-74 etc.). Change the description to reflect that please.

If you want to, you can rename the rest of the weapons and add it to this PR, but imo this is enough as it is.