acemod / ACE3

Open-source realism mod for Arma 3
https://ace3.acemod.org
Other
1k stars 736 forks source link

Overpressure - Add editor range attribute for vehicles #10411

Closed bluefieldcreator closed 1 week ago

bluefieldcreator commented 2 weeks ago

When merged this pull request will:

Problem: if the user has the server setting set to 10 (example) and a mission maker wants to set a vehicle's value to 0, it wont work. Since we check for >= 0.1

I cant figure out a good system other than making an entire new overpressure setting called "enable overpressure" as a checkbox instead of the range slider.

There might be some use cases where a user may want to disable overpressure on some vehicles, and change the values of others, which would require both... so I might update this in the future to add such use case.

Important bits of code: cfgEden.hpp & fnc_firedEHOP.sqf

2nd ever PR i appreciate all feedback. 🥲

IMPORTANT

bluefieldcreator commented 2 weeks ago

Why are all the tabs failing OH MY GOD

bluefieldcreator commented 2 weeks ago

TODO:

bluefieldcreator commented 2 weeks ago

Okay, I fixed EVERYTHING - This PR is ready for review & merge.

bluefieldcreator commented 2 weeks ago

Good catch

bluefieldcreator commented 1 week ago

I think... that's it... I hate the GH phone app, I thought it merged your changes.

My bad

bluefieldcreator commented 1 week ago

Finally... :D