Explosives - Add Tripwire Flare Air Variant

acemod / ACE3

Open-source realism mod for Arma 3

https://ace3.acemod.org

Other

1k stars 736 forks source link

Explosives - Add Tripwire Flare Air Variant #10423

Open Mike-MF opened 2 weeks ago

Mike-MF commented 2 weeks ago

When merged this pull request will:

Adds a new tripflare item that fires into the sky instead of on the ground.
Adds setting for the tripflare colour (default is Red, which i think is what the original one did. Not sure, colourblind.)
Kept the old tripflare class for BWC, just no longer used here.

IMPORTANT

If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
Development Guidelines are read, understood and applied.
Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

PabstMirror commented 2 weeks ago

I'd prefer to just add a 2nd magazine instead of a setting

Mike-MF commented 2 weeks ago

I'd prefer to just add a 2nd magazine instead of a setting

That'd mean duplicated code as the effect only passes the position, so no way of detecting what kind of flare would have been activated. The setting is just the simpler solution here.

Drofseh commented 2 weeks ago

By having a setting and changing it to air mode, all mission that have been previous made with ground flares now have air flares. I don't think that's desirable As a mission maker I might like to be able to give players a mix of ground and air flares, or places a mix in a defended area in the editor.

I don't see a lot of duplicate code being added to implement that. A couple of additions to CfgCloudlets.hpp and something like TripflareAirEffect.sqf that adds a little height to the initial Z position when calling the spawnFlare function.

johnb432 commented 1 week ago

I'm not a huge fan of having the color be a setting. Is there no way we can have it passed as an argument or set as a config entry?

Mike-MF commented 1 week ago

I'm not a huge fan of having the color be a setting. Is there no way we can have it passed as an argument or set as a config entry?

If we do this via config entry it'd mean I'd have to make 3 classes for it which I didn't want to do to begin with. I decided to put it into ACE for simplicity instead of having it in-house via the event.

Drofseh commented 1 week ago

Classes for colours makes sense to me as well, just like the hand flares have a class for each colour

Mike-MF commented 1 week ago

I still don't have a way of knowing anything other than the position, and I'm not going to make 3 separate functions just to fire a different flare colour on a feature virtually nobody uses.

rautamiekka commented 1 week ago

a feature virtually nobody uses.

"Famous last words", as they say.

PabstMirror commented 1 week ago

I can take a look; pretty sure we can swap from the weird effect script thing to the explosion eh

Drofseh commented 1 week ago

a feature virtually nobody uses.

"Famous last words", as they say.

I'm already thinking of having different colour flares for different lines of defence.

tuntematonjr commented 1 week ago

We have inhouse mod that has 4 colors of air and ground trip flares. I could port it to ace, if that is wanted