acemod / ACE3

Open-source realism mod for Arma 3
https://ace3.acemod.org
Other
1.01k stars 737 forks source link

Error when using Group EH "UnitKilled" #10433

Closed PiG13BR closed 1 month ago

PiG13BR commented 1 month ago

Mods (complete and add to the following information):

Description: SP/editor - clean mission: Error in .../addons/medical_feedback/XEH_postInit.sqf when using group EH "UnitKilled". In dedi server .rpt: I've also got an error in the fnc_setDead.sqf. In this case was not a clean mission. More info in the logs below

Steps to reproduce:

  1. Open the editor in VR, place the player unit and some other unit.
  2. In the group init field of that unit, add the "UnitKilled" EH.
  3. Preview the scenario and kill the unit.

Expected behavior: No error showing up.

Where did the issue occur?

Log Files:

Additional context:

Screenshots: Screenshots of the error after killing the unit with the group EH. Thanks to artemoz

johnb432 commented 1 month ago

Given that CBA is also throwing an error, I doubt this is ACE's doing - I doubt it's even CBA's fault. I'll test it myself, but I have a feeling that it's something in 2.18 that's been changed.

PabstMirror commented 1 month ago

ace_medical_death event is running for the object and then the group

PiG13BR commented 1 month ago

I think it's the EH fault. It's returning wrong parameters, at least, wrong order of them. image The _unit parameter should return the killed unit but it's actually returning the _killer.

johnb432 commented 1 month ago

ACE is not the culprit, as it still happens with CBA only:

20:55:16 Error in expression <ariable ["cba_xeh_killedBody", objNull] != _unit) then {                    _uni>
20:55:16   Error position: <!= _unit) then {                    _uni>
20:55:16   Error Generic error in expression
20:55:16  βž₯ Context:    [] L1 ()
    [] L1 ()
PabstMirror commented 1 month ago

It's really just BIS's fault

when adding a "UnitKilled" EH to a group:

so for some reason adding the group event switches the args around 🀑

johnb432 commented 1 month ago

Yea, confirmed that it happens in Vanilla only too.

johnb432 commented 1 month ago

https://feedback.bistudio.com/T185567

PiG13BR commented 1 month ago

Seems like this issue was fixed in 2.18 hotfix. https://dev.arma3.com/post/spotrep-00116

Tested this EH in editor with ace + CBA. No errors. Also checked .rpt file.