acemod / ACE3

Open-source realism mod for Arma 3
https://ace3.acemod.org
Other
1k stars 735 forks source link

class CBA_MiscItem_ItemInfo not backwards compatible to class ItemInfo #5673

Closed Pergor closed 5 years ago

Pergor commented 7 years ago

Arma 3 Version: current (stable) CBA Version: 3.4.1.170912 ACE3 Version: 3.11.0

Mods:

- CBA_A3
- ace

Description:

Steps to reproduce:

class cfgWeapons {
    class ACE_ItemCore;
    class InventoryItem_Base_F;

    class adv_aceCPR_AED: ACE_ItemCore {
        scope = 2;
        displayName = "Automated External Defibrillator";
        picture = "\adv_aceCPR\ui\defib.paa";
        model = "\A3\Structures_F_EPA\Items\Medical\Defibrillator_F.p3d";
        descriptionShort = "Use to resuscitate player";
        descriptionUse = "Use to resuscitate player";
        class ItemInfo: InventoryItem_Base_F {
            mass = 30;
        };
    };
};

Item can't be added to inventory any longer.

class cfgWeapons {
    class ACE_ItemCore;
    class CBA_MiscItem_ItemInfo;

    class adv_aceCPR_AED: ACE_ItemCore {
        scope = 2;
        displayName = "Automated External Defibrillator";
        picture = "\adv_aceCPR\ui\defib.paa";
        model = "\A3\Structures_F_EPA\Items\Medical\Defibrillator_F.p3d";
        descriptionShort = "Use to resuscitate player";
        descriptionUse = "Use to resuscitate player";
        class ItemInfo: CBA_MiscItem_ItemInfo {
            mass = 30;
        };
    };
};

Item works again.

IrLED commented 7 years ago

Many items became of type AccessoryBipod

diag_log format ["%1 -> %2", _x, _x call bis_fnc_itemtype];
}forEach ["ACE_EarPlugs","ACE_RangeCard","ACE_Clacker","ACE_M26_Clacker","ACE_DeadManSwitch","ACE_DefusalKit","ACE_MapTools","ACE_Flashlight_MX991","ACE_Sandbag_empty","ACE_wirecutter","ACE_RangeTable_82mm","ACE_EntrenchingTool","ACE_Cellphone","ACE_CableTie","ACE_SpottingScope","ACE_Tripod","ACE_fieldDressing","ACE_bloodIV_500","ACE_bloodIV","ACE_epinephrine","ACE_morphine","ACE_bodyBag"];
jonpas commented 7 years ago

Yes, CBA_MiscItem is a bipod, a workaround to show them in Virtual Arsenal correctly. And yes, all mods should change it to use CBA_MiscItem_ItemInfo as well, ACE_ItemCore can be kept though.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

jonpas commented 5 years ago

This was solved with other mods getting updated, closing.