acemod / ACE3

Open-source realism mod for Arma 3
https://ace3.acemod.org
Other
994 stars 734 forks source link

Limited arsenal and any available attachment #9927

Open Negaiette opened 3 months ago

Negaiette commented 3 months ago

Mods (complete and add to the following information):

Description: You can take any attachment item from limited arsenal, which not approved in it

Steps to reproduce:

  1. Take any primary weapon, which compatible with attachment. (In my example I will use the scope)
  2. Take any handgun weapon, which compatible with. (PP-2000 from RHSAFRF for example)
  3. Put scope, which u want to take from arsenal on handun weapon or primary weapon.
  4. Open arsenal and select weapon without scope.
  5. Select needed scope on scope's right panel.
  6. Done.

Expected behavior: The sight should not be available for taking

Where did the issue occur?

Additional context: Video with bug demonstration - https://youtu.be/pD8MSDgqMZA

LinkIsGrim commented 3 months ago

@johnb432 duplication, unique virtual attachment is available to multiple weapons

Reproducible in 3.16.3, 3.17.0 and master

johnb432 commented 3 months ago

At this point we have so much technical debt in the arsenal when it comes to unique items that we should rewrite the internals.

LinkIsGrim commented 3 months ago

Already?

johnb432 commented 3 months ago

It feels like it. I'm not sure where to even begin with trying to fix this in a half decent manner in the current system.