search

acendan / reascripts

Scripts written for the digital audio workstation REAPER.
https://aaroncendan.me
MIT License
29 stars 2 forks source link

Markers not updated when changing values #3

Closed StephanRoemer closed 2 years ago

StephanRoemer commented 2 years ago

I just checked your tempo marker script! Really amazing. Just one thing: when changing the values in the GUI, the markers are not updated. You should execute reaper.UpdateTimeline() on value change.

Cheers and thanks!

Stephan

acendan commented 2 years ago

Hi Stephan!

Thanks for letting me know about that. I wasn't able to reproduce your issue, but regardless, the latest version of the Tempo Marker Manager now calls 'UpdateTimeline' after changing marker values. Do note that you'll need to press enter or click to remove focus from a text field in order to update the value of a tempo marker.

Best, Aaron

StephanRoemer commented 2 years ago

Hey Aaron!

Now that was a quick fix, thanks! For completeness, here's a GIF from the old version. The timeline did only get updated when clicking there:

tempo marker

StephanRoemer commented 2 years ago

Ahh, damn, with the new version I found another bug. Adding new markers doesn't update the timeline:

tempo marker insert

acendan commented 2 years ago

Weird! Thanks so much for including the .gifs, as I didn't have the same issue locally whatsoever. They were updated automatically on my end. Out of curiosity, what operating system are you on?

Regardless, I just pushed the fix that should update the timeline for adding markers too!

StephanRoemer commented 2 years ago

Hey Aaron! Thanks a lot!

This is on Windows 10, but I will check in macOS now... Okay, just checked and I got the same behavior with macOS with version 1.5. Version 1.8 works as expected. I wonder what is different on your config. Maybe some kind of defer script in the background, that redraws the timeline / arrange?