search

acerbetti / ACEDrawingView

An open source iOS component to create a drawing app
Apache License 2.0
665 stars 171 forks source link

I have been pointing to 1.3.2 for months #45

Open alokc83 opened 9 years ago

alokc83 commented 9 years ago

Now suddenly when I do pod update. it gets 1.3.5 and screwing up my project. all drawing are screwed. can you tell me what is going on ? Its error on my side or ACEDrawingView Side

Update : I just confirmed that 1.3.5 is broken for Retina displays. I just plugged in 1.3.2 manually in project and everything started to working out of the box. I am not sure if someone already created issue for retina vs non retina displays. if not please consider this as one.

acerbetti commented 9 years ago

Sorry about that, i'm not using this lib in any of my active projects, so probably i've missed the bug

what exactly are the issues of your projects?

It's choice - not chance - that determines our destiny.

On Thu, Jun 11, 2015 at 11:39 AM, Alok Choudhary notifications@github.com wrote:

Now suddenly when I do pod update. it gets 1.3.5 and screwing up my project. all drawing are screwed. can you tell me what is going on ? Its error on my side or ACEDrawingView Side

— Reply to this email directly or view it on GitHub https://github.com/acerbetti/ACEDrawingView/issues/45.

alokc83 commented 9 years ago

past couple of hours I have been trying to compare 132 and 135. I have found out that drawMode is not working as expected. its has totatlly screwed up how ACEDrawingView is saving image. I have tried Scale mode as default is Original. It did nothing. I am quite sure it has been broken for everybody. I am not saying you should sit and fix. but I would request you to revert the drawMode to restore the faith in ACEDrawing view. I personally think you have done awesome job writing this. but this particular piece rendering library useless. issue: if I am running if I am running on non retina sim. everything is fine. but as soon I switch to iPad Air or iPad Retina. image scale is completely blown up. As if its not taking the @2x scale into consideration. When I found this I thought drawMode would fix this problem. but drawMode didnt help either. Please do let me know If I am doing anything wrong. On different note, this might be cocoapods ppl (as from dat before yesterday min required version 0.35.0) Even though my pod file says 1.3.2 it fetches the 1.3.5. We didn't realize until everything around drawingView was broken.

acerbetti commented 9 years ago

Can you provide me an example of the broken issue? If you set the draw mode to ACEDrawingMode to ACEDrawingModeOriginalSize the behavior should be identical as the previous version