acerbilab / pybads

PyBADS: Bayesian Adaptive Direct Search optimization algorithm for model fitting in Python
https://acerbilab.github.io/pybads/
BSD 3-Clause "New" or "Revised" License
69 stars 2 forks source link

`from pybads.bads.bads import BADS` #17

Closed pipme closed 1 year ago

pipme commented 1 year ago

It seems a bit tedious to import this way. Is from pybads import BADS better?

lacerbi commented 1 year ago

Seconded.

GurjeetSinghSangra commented 1 year ago

Oh right! I missed some imports in init.py files, but I fixed them all, and reorganised the code. Just did as you suggested. Now it's possible to import like from pybads import BADS. The PR will be done tomorrow morning.

Just to highlight that now vbmc works with from pyvbmc.vbmc import VBMC, I think it would be nice to have it there too, and we keep both projects with similar rules.

lacerbi commented 1 year ago

Just to highlight that now vbmc works with from pyvbmc.vbmc import VBMC, I think it would be nice to have it there too, and we keep both projects with similar rules.

@Bobby-Huggins

Bobby-Huggins commented 1 year ago

Yes I agree completely, I'll make the same change in PyVBMC.

pipme commented 1 year ago

Fixed in #19.