search

acerbilab / pybads

PyBADS: Bayesian Adaptive Direct Search optimization algorithm for model fitting in Python
https://acerbilab.github.io/pybads/
BSD 3-Clause "New" or "Revised" License
69 stars 2 forks source link

Code style with pre-commit #18

Closed pipme closed 1 year ago

pipme commented 1 year ago

Add pre-commit hooks for formatting. Same as pyvbmc.

GurjeetSinghSangra commented 1 year ago

The two pull requests will have many conflicts for the last commit ("run pre-commit for all files") since the code has been formatted in almost all files. In the 19 PR, I changed and moved many files for fixing the imports. Although it shouldn't change much I believe it would be better to first close the 19 PR and then the 18PR, what do you think? The pre-commit configuration files (commit: "add pre-commit for formatting") are harmless from conflicts. Whatever we decide the merge will consist to overwrite the conflicts with the changes made in PR 19 and then run the pre-commit task.

lacerbi commented 1 year ago

So which one should I merge first?