acerbilab / pyvbmc

PyVBMC: Variational Bayesian Monte Carlo algorithm for posterior and model inference in Python
https://acerbilab.github.io/pyvbmc/
BSD 3-Clause "New" or "Revised" License
114 stars 6 forks source link

refactor: clarify `VBMC._check_termination_conditions()`. #130

Closed Bobby-Huggins closed 1 year ago

Bobby-Huggins commented 1 year ago
  1. Adds a heuristic to avoid exiting after a recent warping to VBMC._check_termination_conditions() (same check as exists in MATLAB version, but it wasn't present in Python).
  2. Removes the assignment of success_flag from VBMC._check_termination_condition(), since the flag is reset based on VP stability at the end of the VBMC main loop.