Closed matt-graham closed 1 year ago
Raising issue as part of JOSS review openjournals/joss-reviews/issues/5428
The docstring for the VBMC class specifies the key in the options dict for specifying to use a noisy log target density as specifytargetnoise
VBMC
options
specifytargetnoise
https://github.com/acerbilab/pyvbmc/blob/b7c6e381be75dd508ac9663825fd77ed8885816d/pyvbmc/vbmc/vbmc.py#L51
while elsewhere in the documentation specify_target_noise is used and this seem to correspond to what's assumed in the code
specify_target_noise
https://github.com/acerbilab/pyvbmc/blob/b7c6e381be75dd508ac9663825fd77ed8885816d/pyvbmc/vbmc/option_configs/basic_vbmc_options.ini#L19
There is also a note indicating PyVBMC does not currently support noisy target density evaluations which I think is no longer true (?) given there is a tutorial example for this case
https://github.com/acerbilab/pyvbmc/blob/b7c6e381be75dd508ac9663825fd77ed8885816d/pyvbmc/vbmc/vbmc.py#L114-L117
Thanks for spotting this!
@Bobby-Huggins can you please fix this when you have the time?
Fixed in pull #140.
Raising issue as part of JOSS review openjournals/joss-reviews/issues/5428
The docstring for the
VBMC
class specifies the key in theoptions
dict for specifying to use a noisy log target density asspecifytargetnoise
https://github.com/acerbilab/pyvbmc/blob/b7c6e381be75dd508ac9663825fd77ed8885816d/pyvbmc/vbmc/vbmc.py#L51
while elsewhere in the documentation
specify_target_noise
is used and this seem to correspond to what's assumed in the codehttps://github.com/acerbilab/pyvbmc/blob/b7c6e381be75dd508ac9663825fd77ed8885816d/pyvbmc/vbmc/option_configs/basic_vbmc_options.ini#L19
There is also a note indicating PyVBMC does not currently support noisy target density evaluations which I think is no longer true (?) given there is a tutorial example for this case
https://github.com/acerbilab/pyvbmc/blob/b7c6e381be75dd508ac9663825fd77ed8885816d/pyvbmc/vbmc/vbmc.py#L114-L117