search

aces / CIVET_Full_Project

CIVET Installer
http://www.bic.mni.mcgill.ca/ServicesSoftware/CIVET-2-1-0-Source-Code-Access-and-Binaries
Other
26 stars 6 forks source link

make untar #8

Closed jennydaman closed 3 years ago

jennydaman commented 4 years ago

Introduction

https://github.com/aces/CIVET_Full_Project/blob/e831b1fc4b56d24a5caea775a201df85800f2739/Makefile#L12

The subcommand make untar was never implemented.

Changes

I've added a line for the described functionality.

Test

make USE_GIT=yes untar

Motivation

it would be useful to have all sources preset from the get-go so that you can patch individual files for non-standard builds. e.g.

https://github.com/aces/CIVET_Full_Project/blob/e831b1fc4b56d24a5caea775a201df85800f2739/Dockerfile#L24-L26

prioux commented 3 years ago

I just noticed this PR. I have no objection in merging this except that the indentation in the Makefile is wrong. @jennydaman can you adjust this please?

prioux commented 3 years ago

It seems it's because the lines are missing an initial TAB characters (tabs are very critical in a Makefile)

prioux commented 3 years ago

Confirmed. My editor highlights TABs in yellow, see the screenshot below:

Screen Shot 2020-10-29 at 12 07 04

prioux commented 3 years ago

Seems fine after visual inspection.