search

aces / EEG2BIDS

EEG2BIDS Wizard: a tool for converting raw EEG and iEEG data into the BIDS standard data structure, prepared for LORIS (Longitudinal Online Research and Imaging System).
MIT License
7 stars 10 forks source link

temporary fix for problem debugged with jesscall #80

Open maltheism opened 2 years ago

maltheism commented 2 years ago

Brief summary of changes

This PR is a temporary solution for the problem debugged with @jesscall. The code for this portion needs to be changed for potential edge cases of the events.tsv file that the user supplies. Example: column headers could not be in the assumed correct order and optional columns could exist that we're currently not handling.

The edge cases that will need to be solved and brought up in that EEG meeting are the following..

  1. The order of the user supplied events.tsv “columns” could be different/mixed.

  2. The optional values could be supplied by the user and code logic needs to account for them.

  3. The BIDS generation can potentially make it’s own events.tsv file and that can be different than the user’s supplied events.tsv file. So the logic has to be able to handle refining the columns order and conflicts like lack of columns or extra columns.

Link(s) to related issue(s)

christinerogers commented 1 year ago

@jeffersoncasimir is this already fixed (should be closed) or could be included in the current/next EEG2BIDS / EDF2BIDS? @laemtl thoughts?

jeffersoncasimir commented 1 year ago

To be tested in August