aces / Loris-MRI

The set of scripts that preprocess and insert MRI data into the database.
10 stars 50 forks source link

[python] EEG-BIDS Events replace Annotations; plus adding HED Support #1041

Closed jeffersoncasimir closed 4 months ago

jeffersoncasimir commented 6 months ago

This PR has multiple Loris counterparts:

Events to Annotations: #9032 HED support: #9033

It aims to make the Python pipeline more compliant with the current BIDS standard.

It does so by replacing references of annotations files and terms with references to events files and terms.

It also brings in support for ingesting dataset-level (from dataset-level events.json) and instance-level (HED column in events.tsv) HED Tags.

Current HED limitations:

It also does some file name refactoring in thedatabase_lib folder to standardize the name structure. Some logic was also moved to new database_lib files.

MAKE SURE YOU PATCH SQL + ADD BOTH SCHEMAS WITH THE insert_hed_schema.php TOOL IN ACES/LORIS PRS FIRST

christinerogers commented 6 months ago

let's change pr title to [EEG-BIDS/python]...

cmadjar commented 6 months ago

@jeffersoncasimir who would best the best person to review this PR?

jeffersoncasimir commented 5 months ago

I think @regisoc or @laemtl would be since they have both reviewed one of the Loris counterparts