aces / Loris-MRI

The set of scripts that preprocess and insert MRI data into the database.
10 stars 51 forks source link

LORIS-MRI tooling configuration (Docker version) #1182

Closed maximemulder closed 2 months ago

maximemulder commented 2 months ago

Alternative to #1170. The differences are the following :

The workflow in this PR is arguably more complex than #1170, but it provides a better isolation and reproducibility for the testing environment. Although this PR caches the whole Docker image instead of just the dependencies, the performance looks similar, as the time gained in the environment setup is lost in launching and stopping the container.

maximemulder commented 2 months ago

Okay, ignoring the messy Git history (kinda too lazy to fix it now) this PR is done. Although this approach has some advantages, it is also slower than the current Python tests setup, so I am not sure if we should merge it. Anyway, I learned quite a bit about Docker and GitHub Actions which will be useful for integration tests. This PR in itself will be a subject of discussion for another meeting.

maximemulder commented 2 months ago

We concluded in the meeting that the dockerization of our Python checks is not worth the complexity and speed hit (~2min) of this PR. Closing.