Closed maximemulder closed 1 week ago
Just one quick question. I named the model for the files
table mri_file.py
. Is this name correct ? Or can there be files that are not MRI @cmadjar ?
@maximemulder there can be files in the files table that are not MRI. I would change to imaging_file.py
instead so that any imaging modality is covered (PET, MRI, MRS etc..)
Ahok makes sense. Do you prefer just file.py
or imaging_file.py
? The latter seems a little long to me but if you prefer it I'll use it instead. I could also use img_file.py
but I don't think we use img
as a shorthand of imaging
anywhere else :thinking:
I think just file.py
makes sense
Okay, I changed the name ! By the way I used file_parameter.py
instead of parameter_file.py
because it makes more sense to group the parameters of a file it with the files than with the parameter types to me. But this is a weak opinion, if you think parameter_file.py
is a better name that's fine by me.
Probably best to stick with parameter_file
like the table name to avoid confusions.
Updated ! Once this is merged I will update the integration test PR to also ensure the files have been inserted in the database (hopefully Friday).
In order to improve the integration tests for
run_dicom_archive_loader.py
. I want to query thefiles
table to make sure the files are inserted in the database. This PR adds SQLAlchemy model definitions for this table (andparameter_file
andmri_scanner
because why not).The integration tests pass therefore the models are correct !