aces / Loris-MRI

The set of scripts that preprocess and insert MRI data into the database.
10 stars 51 forks source link

get_dicom_files.pl can fail on archives that contain files with identical basenames #718

Open nicolasbrossard opened 2 years ago

nicolasbrossard commented 2 years ago

Suppose that you have an archive containing two directories inside which there are two files with the same name. For example A/B/C and X/Y/C. This is a valid content for a zip of .tar.gz archive and the MRI pipeline will process that archive successfully. This can create problems for script get_dicom_files.pl, as it assumes that the base names of the files inside an archive are all distinct. This could make the script extract the wrong C file in the example above. The script should be improved to examine file base names and their md5sum when extracting DICOMs from archives to avoid erroneous extractions.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 1 year with no activity. Remove stale label or comment or this will be closed in 3 months.

github-actions[bot] commented 1 week ago

This issue is stale because it has been open 1 year with no activity. Remove stale label or comment or this will be closed in 3 months.