Remove redundant boilerplate from LORIS PHP files

aces / Loris

LORIS is a web-accessible database solution for longitudinal multi-site studies.

GNU General Public License v3.0

142 stars 172 forks source link

Remove redundant boilerplate from LORIS PHP files #4061

Open johnsaigle opened 5 years ago

johnsaigle commented 5 years ago

Many files have old boilerplate that is unnecessary and in some cases generates notices and warnings.

Red flags are anything found in the generic includes, viz.:

NDB_Client
Database
NDB_Config
Modification of the PHP include path
Starting a session/including NDB_Client

TODO

Remove the above includes/initialization steps from LORIS code, especially module code and ajax scripts. Ensure that no functionality changes.

johnsaigle commented 5 years ago

This is done frequently by old tools/ scripts also.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

johnsaigle commented 4 years ago

We can also now remove the file doc comments from most PHP files in LORIS> As of now, only class comments are required.

"Standalone" scripts, such as tools/ and ajax/ scripts, should still contain a file comment if they do not have a class.

stale[bot] commented 4 years ago

The Stale label is being removed automatically because some activity has occurred or because the developers have decided that this pull request is important and should not continue to be overlooked.