aces / Loris

LORIS is a web-accessible database solution for longitudinal multi-site studies.
GNU General Public License v3.0
145 stars 173 forks source link

[Genomic Browser] Issues with the Profiles Tab Datatable. #6302

Open HenriRabalais opened 4 years ago

HenriRabalais commented 4 years ago

Describe the bug A. Since there are no files uploaded in raisinbread for the Genomic Browser, clicking on a file value is not possible. Therefore, the "viewGenomicFile" file view cannot be tested as outlined by the test plan.

B. When there is a SNP for a candidate, the "Y" can be clicked to go to the SNP for that candidate, but the link is not obvious since it is presented as regular text. (PR SENT #6523)

C. There are no profiles with CNV or CPG data, so clicking on the link for those can't be tested. (PR SENT #6900)

Test Plan Reference: https://github.com/aces/Loris/blob/master/modules/genomic_browser/test/TestPlan.md#special-formated-columns

To Reproduce Steps to reproduce the behavior (attach screenshots if applicable):

  1. Go to the Profiles Tab of the Genomic Browser
  2. Look at the columns for File, SNP, CNV and CPG

image

ridz1208 commented 4 years ago

@xlecours will you be able to address this ?

christinerogers commented 4 years ago

My $0.02:

xlecours commented 4 years ago

@ridz1208 It would be low on my priorities list.

christinerogers commented 4 years ago

I think this issue can be closed after #6523 is resolved/merged to address point B. A and C are not testable in this round at least.

christinerogers commented 4 years ago

splitting off issue C for @AlexandraLivadas : issue 6302

driusan commented 4 years ago

The referenced PR says it only partially resolves this.