[DQT] Define field tab - cannot select a Visit in Visits filter

aces / Loris

LORIS is a web-accessible database solution for longitudinal multi-site studies.

GNU General Public License v3.0

145 stars 173 forks source link

[DQT] Define field tab - cannot select a Visit in Visits filter #6583

Open laemtl opened 4 years ago

laemtl commented 4 years ago

In DQT > Define field tab, the checkboxes in the Visits menu dropdown are not selectable when no fields are selected.

If this is the intended behavior, I suggest adding a visual indication that those checkboxes are disabled.

With some console debugging, I noticed the click event is fired twice.
Observed in Chrome 75.0.3770.80 and Firefox 76.0.1.

To reproduce

Go to Reports > Data Query Tool
Select the Define field tab
Select an instrument
Interact with the Visits filter on the right

AlexandraLivadas commented 4 years ago

@laemtl I observed the same issue when testing today. I think that this behavior makes sense and is therefore intended. But I agree with you that there should be a visual indication that the Visit checkbox is disabled until you select a field.

christinerogers commented 4 years ago

let's file this under Improvements/Cleanup -- cc @maltheism can this nicety be added to the DQT renovation roadmap?

ridz1208 commented 3 years ago

@maltheism I don't believe this was part of the redesign was it ? if so please close the issue