search

aces / Loris

LORIS is a web-accessible database solution for longitudinal multi-site studies.
GNU General Public License v3.0
145 stars 173 forks source link

[Next_stage/battery] When instruments are using instrument permissions they can not be populated at the next_stage step #7435

Closed ridz1208 closed 1 year ago

ridz1208 commented 3 years ago

Describe the bug LORIS allows instruments to use instrument permissions where access to specific instruments can be checked based on a project-specific permission code. This works well to restrict access to a specific instrument in a timepoint but maintain access to the rest of the instruments in the same timepoint

Issue: If a user who does not have the instrument permission tries to "start next stage" the battery will still be populated but a 500 error will be displayed to the user. After a refresh the intrument_list module will be populated regardless...

What did you expect to happen? The battery should be populated without error, it's only access to the instrument that should be restricted, not it's creation

ridz1208 commented 1 year ago

might be fixed by https://github.com/aces/Loris/pull/8290

ridz1208 commented 1 year ago

@miladheshmati to test after above PR is merged

miladheshmati commented 1 year ago

@ridz1208, tested, no issue was found

driusan commented 1 year ago

Fixed according to above comment.