search

aces / Loris

LORIS is a web-accessible database solution for longitudinal multi-site studies.
GNU General Public License v3.0
142 stars 172 forks source link

[Instrument Builder] Test plan inconsistent with Help menu for 'Not answered' options added automatically to element types. #8575

Closed SantiagoTG closed 1 year ago

SantiagoTG commented 1 year ago

Instrument Builder

Currently the 'Test plan' is inconsistent with the 'Help' menu with regards to 'Not answered' options being added automatically to element types. For example, when adding a new 'Text Area' field, a 'Not answered' option is not automatically added to the linst file. The 'Test plan', Step 5 states:

The 'Help' menu states a 'not_answered' option is to be added to dropdowns, but does not specify the other element types:

Thus, the 'Help' menu is inconsistent with what is mentioned in the Test plan. Further, should a 'not_answered' also be automatically added to the 'Numeric' element type?

If 'not_answered' options are to be added automatically, it would be a good idea to see the option or added field displayed in the 'Instrument Builder', or better still to give the option (via a checkbox) to "Include a 'Not answered' field/option".

zaliqarosli commented 1 year ago

hey @SantiagoTG you say in the description of this issue that

Currently the 'Test plan' is inconsistent with the 'Help' menu with regards to 'Not answered' options being added automatically to element types. For example, when adding a new 'Text Area' field, a 'Not answered' option is not automatically added to the linst file. The 'Test plan', Step 5 states:

For the part I bolded, are you saying this is what is happening or should happen with the instrument builder? As far as I know, 'Text Area' fields do and should have a 'Not Answered' option added to it so I'm a bit confused by your statement

SantiagoTG commented 1 year ago

Hi @zaliqarosli, I now see the 'Not Answered' option being added, so this part of the issue appears to be ok. Not sure why it was not showing when I first tested it or if I missed it altogether, but in my last attempt it appears to add the NA. However, it would still be a good idea to add the NA option for 'Numeric' element types, and furthermore, to allow the user to decide whether to include or not the NA option for all element types.

racostas commented 1 year ago

Hi @SantiagoTG and @zaliqarosli, the NA option for "Numeric' types it is added. I tested that.

The second part, regarding the user to decide, was discussed with @driusan and agreed it is a feature request not a bug fix and should be not addressed as part of the 25-release. I issue was created as referenced in this PR on https://github.com/aces/Loris/issues/8660

driusan commented 1 year ago

I believe this is fixed by the above PR and the part that isn't fixed is in #8660. Feel free to re-open if I'm mistaken.