search

aces / Loris

LORIS is a web-accessible database solution for longitudinal multi-site studies.
GNU General Public License v3.0
142 stars 172 forks source link

[module_manager] - My preferences still available after deactivation #8695

Closed charliehenrib closed 1 year ago

charliehenrib commented 1 year ago

Describe the bug When I deactivate my preferences in the module manager, it still appears under my name and when I click on it, I get a 404 error:

image

To Reproduce Steps to reproduce the behavior (attach screenshots if applicable):

  1. Go to module manager
  2. Deactivate my preferences
  3. Reload the page and click on my preferences
  4. See error 404.

What did you expect to happen? A clear and concise description of what you expected to happen. when I click on my name, I should not see the option for my preferences module.

driusan commented 1 year ago

@jeffersoncasimir Usually the menu items come from the module->getMenuItems() call but that's only true for the main dropdown menu items. This one might need special casing in the smarty template. Let me know if you have any questions or problems fixing it or if you need help with it.

driusan commented 1 year ago

Fixed by above PR