aces / Loris

LORIS is a web-accessible database solution for longitudinal multi-site studies.
GNU General Public License v3.0
145 stars 173 forks source link

[imaging_uploader] Visit Label populated from the entire end of the file name #8803

Closed zaliqarosli closed 1 year ago

zaliqarosli commented 1 year ago

Visit Label should only be populated by the third parameter in the file name, not the rest of the file name after CandID (as is what's happening)

The "Notes" below the uploader states "For files that are not Phantom Scans, file name must begin with [PSCID][CandID][Visit Label]", so anything after VisitLabel should be accepted, even if not a required parameter

i.e. in the screenshot (1), Visit Label is auto-populated as 'MRI02_MNI_20230428_105929723' when should just be 'MRI02'. The Visit Label incorrectly populating results in an error (2).

(1)Screenshot 2023-06-20 at 6 37 33 PM

(2)Screenshot 2023-06-20 at 6 41 09 PM

To Reproduce Steps to reproduce the behavior (attach screenshots if applicable):

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

What did you expect to happen? A clear and concise description of what you expected to happen.

Browser Environment (please complete the following information):

Server Environment (if known): Note: We only support the most recent release of LORIS.

Additional context Add any other context about the problem here.

ridz1208 commented 1 year ago

@zaliqarosli issues started here https://github.com/aces/Loris/pull/5306

zaliqarosli commented 1 year ago

PR merged