search

aces / Loris

LORIS is a web-accessible database solution for longitudinal multi-site studies.
GNU General Public License v3.0
141 stars 173 forks source link

[tools] Refactor recreate_conflicts.php to use getInstrumentNamesList() #9280

Closed ay-bh closed 1 month ago

ay-bh commented 1 month ago

Brief summary of changes

Refactored recreate_conflicts.php to replace the deprecated Utility::getAllInstruments() function with NDB_BVL_Instrument::getInstrumentNamesList($lorisInstance)

Testing instructions (if applicable)

  1. Navigate to /var/www/loris/tools.
  2. Run the script with the command php recreate_conflicts.php all.
  3. Verify that the script runs without the deprecation error and correctly retrieves all instrument names.

Link(s) to related issue(s)

racostas commented 1 month ago

@ridz1208 , @driusan, this one looks good to me. I think could be valuable for loris 26 if we have time yet. I leave the final review/approval to you.

@ay-bh is one of our new GSoC student (tagging @christinerogers). This it his first PR to our repo. Next time he will make the PR from a different branch that main (it is my fault here since I forgot to mention this convention to him).

Thanks.