Open MaximeMulder opened 1 week ago
I would like to have some opinions on the alternatives before merging. Also I don't know who should review it so I'll just ping @ridz1208 and feel free to give your opinion or re-assign it.
After the MRI meeting today, we agreed on the following TODOs before reviewing/merging this PR :
Summary of changes
Scan_type
foreign key fields toMriScanTypeID
.0
formri_protocol.MriScanTypeID
(as this is a non-nullable foreign key, I don't think this should ever happen).Testing instructions
As we unfortunately have a very loose typing in LORIS, I may have missed a few bugs when adapting the scripts, but we're early on the next version development cycle so I guess it's the right time to do such changes.
Alternatives
ScanTypeID
(it's obvious it's an "MRI" scan type).files.AcquisitionTypeID
also be renamed tofiles.MriScanTypeID
?mri_scan_type.Scan_type
be renamed tomri_scan_type.Name
?Related issues