search

aces / brainbrowser

Web-based visualization tools for neurological data.
https://brainbrowser.cbrain.mcgill.ca/
GNU Affero General Public License v3.0
351 stars 122 forks source link

Add select nifti #268

Closed natacha-beck closed 8 years ago

rdvincent commented 8 years ago

I don't think it's a major problem, but your pull request seems to contain three extra commits - only the last one, 5b32fb1, seems to be relevant.

rdvincent commented 8 years ago

I am not completely sure, but I think you might need to rebase this branch on master. That might fix the issue.

natacha-beck commented 8 years ago

Yes sorry I will do that this afternoon and do an other PR. This one should be closed.

Friday we (the CBRAIN team) will present our ongoing work since your cannot be there can I show a demo of the Nifti viewer and talk about the fix for the overlay ?

Natacha

2015-09-30 12:15 GMT-04:00 Robert D Vincent notifications@github.com:

I am not completely sure, but I think you might need to rebase this branch on master. That might fix the issue.

— Reply to this email directly or view it on GitHub https://github.com/aces/brainbrowser/pull/268#issuecomment-144464591.

rdvincent commented 8 years ago

Sounds great. I just realized that the zoom function was not working right in the overlay, and I am fixing it.

On Wed, Sep 30, 2015 at 12:48 PM, natacha-beck notifications@github.com wrote:

Yes sorry I will do that this afternoon and do an other PR. This one should be closed.

Friday we (the CBRAIN team) will present our ongoing work since your cannot be there can I show a demo of the Nifti viewer and talk about the fix for the overlay ?

Natacha

2015-09-30 12:15 GMT-04:00 Robert D Vincent notifications@github.com:

I am not completely sure, but I think you might need to rebase this branch on master. That might fix the issue.

— Reply to this email directly or view it on GitHub https://github.com/aces/brainbrowser/pull/268#issuecomment-144464591.

— Reply to this email directly or view it on GitHub https://github.com/aces/brainbrowser/pull/268#issuecomment-144473164.

natacha-beck commented 8 years ago

I just create a new PR. I will take a look to yours PR.

2015-09-30 12:52 GMT-04:00 Robert D Vincent notifications@github.com:

Sounds great. I just realized that the zoom function was not working right in the overlay, and I am fixing it.

On Wed, Sep 30, 2015 at 12:48 PM, natacha-beck notifications@github.com wrote:

Yes sorry I will do that this afternoon and do an other PR. This one should be closed.

Friday we (the CBRAIN team) will present our ongoing work since your cannot be there can I show a demo of the Nifti viewer and talk about the fix for the overlay ?

Natacha

2015-09-30 12:15 GMT-04:00 Robert D Vincent notifications@github.com:

I am not completely sure, but I think you might need to rebase this branch on master. That might fix the issue.

— Reply to this email directly or view it on GitHub <https://github.com/aces/brainbrowser/pull/268#issuecomment-144464591 .

— Reply to this email directly or view it on GitHub https://github.com/aces/brainbrowser/pull/268#issuecomment-144473164.

— Reply to this email directly or view it on GitHub https://github.com/aces/brainbrowser/pull/268#issuecomment-144473962.