Closed natacha-beck closed 8 years ago
Here is some issue reported:
Grid length
conflict with auto resize. --> fixedAt this point all the previous comments are fixed. Please take a look and let me know if you find something.
New batch of comment from @lblewis :
From @jonathanlurie :
Need to fix this one from @lblewis
Fix the 'model centric' part.
Just fix the last bug that @lblewis had mention. Please go head for a code review.
With @jonathanlurie we have observed some strange behaviour concerning the grid. When a user manipulates the opacity of the shape, then the grid resizes, but the center of rotation stays the same; this kind of behaviour can thus generate some strange effects (this comportement is insync with @lblewis version).
@rdvincent I just done the update, with your comments.
In this PR I tried to merge everything from Lindsay work on the BigBrain viewer the code source can be found here.
For the moment you will found the bigbrain viewer under examples/bigbrain-viewer, in this way you can test the functionality.
I tried to generalize the functionality added by Lindsay and to put this one in appropriate files (see
viewer.gridHelper
for example). I also fixed some little stuffs in same time.Here is some notes about what I have done during the merge process:
Here is some general comment/issue that seems to be present:
???
)Please let me know all yours comments, I'm sure this PR have place for improvement.