search

aces / brainbrowser

Web-based visualization tools for neurological data.
https://brainbrowser.cbrain.mcgill.ca/
GNU Affero General Public License v3.0
351 stars 122 forks source link

fix mniobj Lines load when color is set per line #324

Closed rentzso closed 7 years ago

rentzso commented 7 years ago

following when colour.flag is 1: http://www.bic.mni.mcgill.ca/users/mishkin/mni_obj_format.pdf

rdvincent commented 7 years ago

Looks good to me.

rentzso commented 7 years ago

Thanks @rdvincent! When do you think this could be merged into master?

natacha-beck commented 7 years ago

@rentzso Everything seems good for me too, but I would like to have a file to play with it.

rentzso commented 7 years ago

You can check these two files: cube.obj.zip https://dl.dropboxusercontent.com/u/39271033/multiple_colors.obj

natacha-beck commented 7 years ago

Hi Renzo, as we start to have more developer on BrainBrowser and we will have more external collaborator soon, we decide to create a dev branch in order to work with a better git workflow. So can you please re-do your PR on the dev branch ? Once you create the new PR I will merge, everything seems ok for me.

rentzso commented 7 years ago

Sure.