search

aces / cbrain-plugins-neuro

5 stars 20 forks source link

Updated xASL and PhysIO #248

Closed dariusvalevicius closed 2 years ago

dariusvalevicius commented 2 years ago

Bugfix to xASL and refactoring for PhysIO, plus cleaner commenting.

PhysIO descriptor and docker image renamed to physio_cbrain (old tool should be retired).

natacha-beck commented 2 years ago

Why does this PR include code about Oxford ASL ? (descriptor + userfiles output) ?

natacha-beck commented 2 years ago

For Physio, can you for now use your repo https://github.com/dariusvalevicius/PhysIO_CBRAIN for the PR ? Since it is the one we use in CBRAIN.

dariusvalevicius commented 2 years ago

Why does this PR include code about Oxford ASL ? (descriptor + userfiles output) ?

Oh, not sure, I think that should have been pushed in a previous PR? I only mean to include the most recent commit. I can try again to do that.

For Physio, can you for now use your repo https://github.com/dariusvalevicius/PhysIO_CBRAIN for the PR ? Since it is the one we use in CBRAIN.

Is there a way to selectively push the boutiques_descriptors folder to cbrain-plugins-neuro from that repo?

natacha-beck commented 2 years ago

I think the easy way is to close this PR and open a new one with only the explore-asl file.