search

aces / cbrain-plugins-neuro

5 stars 20 forks source link

[UPDATE] PhysIO wrapper 1.2.0 #269

Closed dariusvalevicius closed 1 year ago

dariusvalevicius commented 1 year ago

Note to Natacha - I changed the image version from 8.1.0 (physIO version) to 1.2.0 (wrapper version). I considered changing my versioning scheme to match the tool version as per Pierre's earlier comment, but finally I think it's best too keep my wrapper-based versioning scheme for my images (the tool version is still in the descriptor and that is what is shown to the user at launch).

The main changes in this patch are fixing memory issues and throwing exceptions on bad input.

prioux commented 1 year ago

The upper-lower case conventions are not respected. As I verify this in the Ruby console:

Bianca main :002 > 'PhysIOOutput'.underscore
 => "phys_io_output" 
Bianca main :003 > "phys_io_output".classify
 => "PhysIoOutput" 
Bianca main :004 > "physio_output".classify
 => "PhysioOutput"
dariusvalevicius commented 1 year ago

The upper-lower case conventions are not respected. As I verify this in the Ruby console:

Bianca main :002 > 'PhysIOOutput'.underscore
 => "phys_io_output" 
Bianca main :003 > "phys_io_output".classify
 => "PhysIoOutput" 
Bianca main :004 > "physio_output".classify
 => "PhysioOutput"

Ah, I had used the capital IO to keep it from being too generic ("Physio"). I've changed it to "TapasPhysioOutput".

prioux commented 1 year ago

Looks good to me