eliminate codebase and test suits dependency on plugins

aces / cbrain

CBRAIN is a flexible Ruby on Rails framework for accessing and processing of large data on high-performance computing infrastructures.

GNU General Public License v3.0

71 stars 42 forks source link

eliminate codebase and test suits dependency on plugins #1032

Closed MontrealSergiy closed 4 years ago

MontrealSergiy commented 4 years ago

CBrain should be usable with any set of plugings. However codebase and unittest depend on presence of certain plugins (e.g. TextFile). Would it be better to put most necessary plugins in the repo or create separate plugins test suits? Not sure how feasible that though.

natacha-beck commented 4 years ago

@MontrealSergiy the TextFile plugins and some other are included in CBRAIN code base directly (in cbrain-plugins-base): --> https://github.com/aces/cbrain/tree/master/BrainPortal/cbrain_plugins/cbrain-plugins-base/userfiles So I don't think we create external dependence.

prioux commented 4 years ago

Yes, cbrain-plugins-base is a built-in plugin. It cannot be distributed separately either, because it contains some core models used throughout the platform (e.g. SingleFile, FileCollection).