aces / cbrain

CBRAIN is a flexible Ruby on Rails framework for accessing and processing of large data on high-performance computing infrastructures.
GNU General Public License v3.0
71 stars 42 forks source link

Improve the `select_all` mechanism #1243

Closed natacha-beck closed 2 years ago

natacha-beck commented 2 years ago

This PR should improve the mechanism of the select_all mechanism (used in CIVET tools for example).

Multiple cases:

In meantime, I add a hidden input in order to keep track of the state of the select_all that can be all or none.

MontrealSergiy commented 2 years ago

How to test it? Is there description of issues (or #) that this PR addresses?

natacha-beck commented 2 years ago

Please wait to test it. I have some things to fix before testing. I am on it.

On Mon, Jun 6, 2022 at 1:18 PM Serge @.***> wrote:

How to test it? Is there description of issues (or #) that this PR addresses?

— Reply to this email directly, view it on GitHub https://github.com/aces/cbrain/pull/1243#issuecomment-1147688133, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAF525VPCXHBT4SFZIDDDQ3VNYXFBANCNFSM5XOLMHQQ . You are receiving this because you were assigned.Message ID: @.***>

prioux commented 2 years ago

This PR has design issues that were identified last week, Natacha has to work on it some more.

prioux commented 2 years ago

I converted this PR to 'draft'

natacha-beck commented 2 years ago

I think it is ready to test now.

It come with the following PR in cbrain-plugins-neuro:

To test it you need for civet_macaque:

And t2 and pd files associated with them:

The ideas is to allow the user to save preset, without the Use multispectral classification? for example.

Due to limitation it will save as all or none. We cannot save the list of all the files with a status of all the select_all checkbox.

natacha-beck commented 2 years ago

@MontrealSergiy please test it with Chrome instead of Firefox it will maybe fix your issue. I had the same issue on my side, it was due to issue with the assets loading in dev mod.

MontrealSergiy commented 2 years ago

I tested with chrome same thing. Do I need to upgrade to the latest version of Chrome?

MontrealSergiy commented 2 years ago

file type detection still works bad but saving preset worked this time

MontrealSergiy commented 2 years ago

the 'all' checkbox also disappears when one of sub checkboxes is unchecked, as intended

I installed a vm with new chrome, I do not have control over my workstation chrome versions image

natacha-beck commented 2 years ago

I currently work on it. Please wait for the review @MontrealSergiy