Closed natacha-beck closed 2 years ago
How to test it? Is there description of issues (or #) that this PR addresses?
Please wait to test it. I have some things to fix before testing. I am on it.
On Mon, Jun 6, 2022 at 1:18 PM Serge @.***> wrote:
How to test it? Is there description of issues (or #) that this PR addresses?
— Reply to this email directly, view it on GitHub https://github.com/aces/cbrain/pull/1243#issuecomment-1147688133, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAF525VPCXHBT4SFZIDDDQ3VNYXFBANCNFSM5XOLMHQQ . You are receiving this because you were assigned.Message ID: @.***>
This PR has design issues that were identified last week, Natacha has to work on it some more.
I converted this PR to 'draft'
I think it is ready to test now.
It come with the following PR in cbrain-plugins-neuro:
To test it you need for civet_macaque:
And t2 and pd files associated with them:
abc_t1.mnc
, you should have abc_t2.mnc
and abc_pd.mnc
The ideas is to allow the user to save preset, without the Use multispectral classification?
for example.
Due to limitation it will save as all or none. We cannot save the list of all the files with a status of all the select_all
checkbox.
@MontrealSergiy please test it with Chrome instead of Firefox it will maybe fix your issue. I had the same issue on my side, it was due to issue with the assets loading in dev mod.
I tested with chrome same thing. Do I need to upgrade to the latest version of Chrome?
file type detection still works bad but saving preset worked this time
the 'all' checkbox also disappears when one of sub checkboxes is unchecked, as intended
I installed a vm with new chrome, I do not have control over my workstation chrome versions
I currently work on it. Please wait for the review @MontrealSergiy
This PR should improve the mechanism of the
select_all
mechanism (used in CIVET tools for example).Multiple cases:
select_all
checkbox is clicked all the attached checkboxes are selected.select_all
checkbox is deselected.select_all
is checked again.In meantime, I add a
hidden
input in order to keep track of the state of theselect_all
that can beall
ornone
.