search

aces / cbrain

CBRAIN is a flexible Ruby on Rails framework for accessing and processing of large data on high-performance computing infrastructures.
GNU General Public License v3.0
71 stars 42 forks source link

Boutiques parameter values Fixer module #1254

Closed MontrealSergiy closed 8 months ago

MontrealSergiy commented 2 years ago

addresses issue #1188 It did not fit in 20 lines due to some basic handling of constraints/dependencies.

If must I can do stripped down version, yet I feel there could be constraints/dependencies among preset params even in case of the resource control, for example options to use min memory possibly and memory below threshold could be mutually exclusive.

test file with dependencies could be

https://github.com/MontrealSergiy/cbrain-plugins-test/blob/fixer/boutiques_descriptors/dependencyhell.json

natacha-beck commented 2 years ago

You said, it fix the issue 1254:

addresses issue https://github.com/aces/cbrain/pull/1254 ,

But you link to the pull request can you point to the issue.

MontrealSergiy commented 2 years ago

But you link to the pull request can you point to the issue.

done

MontrealSergiy commented 9 months ago

not sure is it ok to rebase on master (most recent) or dev

prioux commented 8 months ago

The new version seems OK, I will test it and if it works I will merge it