aces / cbrain

CBRAIN is a flexible Ruby on Rails framework for accessing and processing of large data on high-performance computing infrastructures.
GNU General Public License v3.0
71 stars 42 forks source link

[RM] unused attributes from Remote Resource #1264

Closed natacha-beck closed 2 years ago

natacha-beck commented 2 years ago

Closed #1227 and closed #1232

prioux commented 2 years ago

(IGNORE THIS) This PR is leaving other places in the code base that refer to the port numbers. See the files in

BrainPortal/config/console_rc/lib (NOTE: never mind, it's fine, I was looking at other port numbers there)

prioux commented 2 years ago

Also, rebase.

prioux commented 2 years ago

I would like this file also updated:

https://github.com/aces/cbrain/blob/master/BrainPortal/app/views/bourreaux/_notes.html.erb

and the wiki:

https://github.com/aces/cbrain/wiki/Bourreau-Setup#3-bourreau-configuration

natacha-beck commented 2 years ago

I would like this file also updated:

https://github.com/aces/cbrain/blob/master/BrainPortal/app/views/bourreaux/_notes.html.erb

--> I am not 100% sure, should I remove everything that is after line 75 https://github.com/aces/cbrain/blob/master/BrainPortal/app/views/bourreaux/_notes.html.erb#L75

natacha-beck commented 2 years ago

and the wiki:

https://github.com/aces/cbrain/wiki/Bourreau-Setup#3-bourreau-configuration

And here I should remove the In the Tunnelling Configuration section section right ?

prioux commented 2 years ago

About "_notes.html.erb" : There are several sections that need adjustments:

prioux commented 2 years ago

For the wiki page, yes, just remove the paragraph.

natacha-beck commented 2 years ago

I think I fixed the code according to your PR @prioux.

Find here the wiki modifications.

prioux commented 2 years ago

I think you made a mistake when you rebased or re-arranged this PR. The migration file is no longer in the PR. Can you compare please the set of files modified here (4 files) with the set of files that were modified before you re-arranged everything, just to make sure, in case other file changes are also missing?