search

aces / cbrain

CBRAIN is a flexible Ruby on Rails framework for accessing and processing of large data on high-performance computing infrastructures.
GNU General Public License v3.0
71 stars 42 forks source link

Userfile show issue when file is not locally sync. #1301

Closed natacha-beck closed 1 year ago

natacha-beck commented 1 year ago

When looking at a file viewable by BrainBrowser that is not locally sync I get the following issue:

image

My suggestion is to look if the file is locally sync at l278 of app/views/userfiles/show.html.erb, here: https://github.com/aces/cbrain/blob/master/BrainPortal/app/views/userfiles/show.html.erb#L279

prioux commented 1 year ago

Fixed in latest commit https://github.com/aces/cbrain/commit/001bb92a98fb50d0ddab99280f82e8fe2b02f411

prioux commented 1 year ago

I'm re-opening this because I realized that the old code had support for some viewers which were available even when the userfile is not synced. It's probably very rare and maybe not even used, though. So I need to check existing viewers to see which ones are like that.

prioux commented 1 year ago

The ONLY place where we have a viewer with direct data provider streaming is in the MacaccCollection (yes, spelled correctly), which is no longer supported anyway. So we're good I think.