aces / cbrain

CBRAIN is a flexible Ruby on Rails framework for accessing and processing of large data on high-performance computing infrastructures.
GNU General Public License v3.0
70 stars 43 forks source link

BoutiquesDescriptorMaker need to verify the IDs in the groups #1339

Closed prioux closed 1 year ago

prioux commented 1 year ago

The BoutiquesDescriptorMaker tool is a development tool that allows users to preview a BTQ descriptor. It's meant for developers.

The developer using it is free to edit the text of the JSON file, and it will be validated and, if correct, a preview of the generated form is shown.

It catches most errors, except one. If the "groups" entries in the descriptor contains, in the 'members' entries, an ID for an input the doesn't exist, the bosh valodator will not complain, and the form generator will crash completely.

So the BoutiquesDescriptorMaker code should do its own validation of that thing and prevent the form from being generated (or remove the offending IDs ?)

prioux commented 1 year ago

I fixed this yesterday and today:

https://github.com/aces/cbrain/compare/ef99c2f..97d923