search

aces / cbrain

CBRAIN is a flexible Ruby on Rails framework for accessing and processing of large data on high-performance computing infrastructures.
GNU General Public License v3.0
71 stars 43 forks source link

Refacto OIDC 3 #1405

Closed natacha-beck closed 2 months ago

natacha-beck commented 3 months ago

@prioux and @MontrealSergiy I think it is now ready for review.

prioux commented 2 months ago

Can you please include the Globus record in your oidc.yml.rb file please? Also, this file will become part of the official distribution of CBRAIN, so it should contain

  1. a comment block at the top explaining its purpose
  2. all the configs should come with enabled: false, not true like in your commit, otherwise somebody installing a portal would get a non-functionning CBRAIN that crashes with a misconfigured keycloak auth service
prioux commented 2 months ago

My first step in reviewing this PR is to make sure that all features related to Globus have been preserved.

Right now, on my dev system, I have configured a Globus identity provider in the oidc.yml.erb file, and my server boots, but I can't go any further. The 'my account' page doesn't provide any way to link my account it globus.

Original CBRAIN code screenshot:

Screen Shot 2024-07-16 at 13 29 44

This PR's code screenshot:

Screen Shot 2024-07-16 at 13 30 02

natacha-beck commented 2 months ago

Replaced by https://github.com/aces/cbrain/pull/1412