NeuroHub bugs checklist

prioux commented 4 years ago

Enter NeuroHub bugs/limitations below as a checklist. Checkboxes are created with dash, space, square bracket, space, square bracket, space (- [ ] Text).

[ ] When account is created, the user is redirected to cbrain with no way of signing in to NeuroHub.
[ ] Pagination defaults to 20 even if there are less than 20 items.
[ ] In the upload file form, if the user doesn't fill in a required input, he/she is only notified of the error through flash notice after being redirected to the projects page. It would be nice to have a warning when there's missing information much like with the user register form.
[ ] Check that all cbrain links are external and open in new tab. (I already checked but would like someone to double check if they have time in case I missed any. - Candice)
[x] user should be able only add storage to a project if he is editor or maintainer at the least, remove irrelevant projects from the create new storage forms' project dropdown. IF I am wrong and it is fine for any contributor to add projects storage, put back the add storage button to non-editable projects. (Natacha note: I am able to add a DP to a PUBLIC project via CBRAIN, when I use a user (SiteManager) that is a member of this group but not an Editor. I should not be able to do that.)
[x] If an Editor of a public project has the same right than the creator then it should be able to add a licence to the group. It is not the case for the moment. @prioux can you confirm that an editor should have this ability.

For the list of bugs resolved by April 7 click here For the list of bugs resolved by April 15 click here For the list of bugs resolved by April 16 click here For the list of bugs resolved by April 20 click here For the list of bugs resolved by April 22 click here For the list of bugs resolved by April 29 click here

MontrealSergiy commented 4 years ago

@prioux Should I add a Project link to My Account or @candicecz to the menu bar?

prioux commented 4 years ago

Added a bug in project show page

natacha-beck commented 4 years ago

Added 2 new bugs.

emmetaobrien commented 4 years ago

[ ] In the "NeuroHub Architectural Components" section on https://neurohub.ca/vision.html we still list the OSF portal as our candidate technology for the portal space.

adora07 commented 4 years ago

[ ] In the "NeuroHub Architectural Components" section on https://neurohub.ca/vision.html we still list the OSF portal as our candidate technology for the portal space.

@emmetaobrien can you log this issue? would like JB to ok the removal of this.

emmetaobrien commented 4 years ago

@adora07: I had thought here was the appropriate place for noting things of this scale; where should I log that?

adora07 commented 4 years ago

@emmetaobrien for the https://neurohub.ca website (not portal), log issues here: https://github.com/neurohub/neurohub.github.io/issues

emmetaobrien commented 4 years ago

Checking in there, my comment turns out to be a duplicate of https://github.com/neurohub/neurohub.github.io/issues/3

prioux commented 4 years ago

@candicecz Added an issue for you in the check list above.

prioux commented 4 years ago

@candicecz Added one more feature request (powered by cbrain)

prioux commented 4 years ago

@candicecz Added one more feature request (who am I in top bar)

natacha-beck commented 4 years ago

@candicecz Added a bug.

natacha-beck commented 4 years ago

@candicecz I am able to accept the invitation in the Dashboard (I really like the idea to have it in the Dashboard). But I am not able to accept it in the nh_invitations index page.

xlecours commented 4 years ago

@prioux "bug/feature request" added about opening a new window when switching to CBRAIN's UI.

prioux commented 4 years ago

@xlecours Yes, good idea

prioux commented 4 years ago

@candicecz UI suggestion added

prioux commented 4 years ago

@candicecz thirs UI suggestion (View Licenses) added

natacha-beck commented 4 years ago

@candicecz +1 for UI suggestion: do we need to repeat the links to dashboard, my account etc in the footer?

candicecz commented 4 years ago

I'm still thinking about this. I think the answer will become more clear in time so I'm leaving it for now. I think once I create pagination for projects, userfiles, etc then we probably won't need it.

prioux commented 4 years ago

This entry logs completed bullet points as of Apr 7th.

[x] Cannot return to project list page from MyAccount page
[x] No error message when filling registration form incorrectly
[x] Created a signup, was redirected to a page that does not exist (url is wrong, contains dot instead of slash)
[x] Flash message do not render properly in the login page (e.g. when account is locked)
[x] The project 'show' page inverts the name of the project and the name of the creator
[x] The HBHL logo at the top link to nh_session, it is not a valid route. Not sure about the right link to put here.
[x] Link to INVITATIONS could be only present in the toolbar if user have pending invitations.
[x] Too much unnecessary uppercasing in the interface. The project buttons list for instance shows all the project names in uppercase; given that sometimes casing is an important carrier of information, it should respect the creator's original casing. Also, the names can often be part of API calls, so it need to be show faithfully in case the user selects them from the interface with cut-and-paste. Other example: creator name in the projects. Candice, please review all interface elements to change unnecessary uppercasing.
[x] Add a 'powered by CBRAIN' footer. Small and discreet; at the bottom of all pages; see main CBRAIN site for example. Use layout system to make it general (do not need to add this to each page individually)
[x] I'd like to know who I am without having to click on 'My Account'. My username should be shown somewhere in the top bar... ?
[x] In the Neurohub interface I am not able anymore to accept an invitation.

MontrealSergiy commented 4 years ago

I can try a better name for that file (Minor, about the source code) File views/nh_projects/_form_for.html.erb should be renamed. Why is there a '_for' in there, it's not like the Rails method...)

prioux commented 4 years ago

Just to avoid merge conflicts, I'd rather let @candicecz do changes to UI-related files, it's her domain after all.

MontrealSergiy commented 4 years ago

As you wish. I am sure @candicecz can do it as well (or even better),

prioux commented 4 years ago

Added comment about too many fles.

MontrealSergiy commented 4 years ago

@prioux do you want reimplement paging manually? Another option could be use some small paging library (gem) like pagy https://github.com/ddnexus/pagy , I can try if you are fine

candicecz commented 4 years ago

@prioux @MontrealSergiy I'm currently working on the tables (reformatting + adding pagination). I'm working on pagination the way it currently works on CBRAIN. Let me know if I should be doing things different.

MontrealSergiy commented 4 years ago

@candicecz I do not mind, ignore that comment then

prioux commented 4 years ago

@MontrealSergiy OK after dicussions with @candicecz I think you can start investigating that 'pagy' Gem. What I want:

1) simple minimal code for pagniation of the files index page 2) only minor changes to controller and a few new buttons or links on the index page to support pagination 3) do it in a separate branch and make a PR

prioux commented 4 years ago

Once this works for the files index page we'll add the same functionality for the projects index page (both list and button views)

prioux commented 4 years ago

@candicecz : added a tiny bug on the cbrain side caused by one of your changes (title helper method)

@MontrealSergiy : added a tiny bug on the cbrain side cause by your licensing code

MontrealSergiy commented 4 years ago

the license bug is fixed, files are paged.

prioux commented 4 years ago

Added a search box bug report for @natacha-beck

MontrealSergiy commented 4 years ago

@prioux should I add paging to the project list? Or ok for now?

prioux commented 4 years ago

@MontrealSergiy Yes please, you actually anticipated what I was going to ask. But make sure you synchronize your modifications with @candicecz first so that you guys don't modify the same files at the same time.

candicecz commented 4 years ago

@MontrealSergiy Could you also add an input field so that the user can modify the number of files/projects to show per page?

MontrealSergiy commented 4 years ago

ok

prioux commented 4 years ago

@natacha-beck Added a bug with the invitation controller

prioux commented 4 years ago

Issues closed as of Apr 15th

[x] We need to put a limit on the number of files shown, or implement pagination. I clicked on a project with >80K files and it took a long time to render the page. And it's useless too.
[x] (Sergiy) Bug: the license_check callback for the CBRAIN side fails when the user switches to "no active project" (with id=all).
[x] (Natacha) The search box is broken again. I tried 'abide' and internal exceptions were raised.
[x] If someone tries to accept an invitation for a project which no longer exists, an exception is created. Line 90 in controller: @nh_project = @nh_invitation.group. A message should be shown and the invitation cancelled/deleted.

candicecz commented 4 years ago

Issues closed as of Apr 16th

[x] The upload file button that redirect to CBRAIN's UI should open a new window/tag because there is no way for the user to come back to the NeuroHub UI.
[x] UI suggestion. Whemever there is a link that takes the user to CBRAIN, why not add a tiny [cb] logo after it? (we could use the small square blue-and-white [cb] logo)
[x] UI suggestion: do we need to repeat the links to dashboard, my account etc in the footer?
[x] UI suggestion: On the Dashboard you will see a new search box, when used it will redirect to a pages with the result of the search. This page need to be improve @candicecz .
[x] (Candice) Bug: Some neurohub changes to the title() helper is messing up the layout of the titles in the CBRAIN page (e.g. the DataProvider pages shows up as -DataProviders
[x] Remove the little standalone dash in the descriptions of projects that have no descriptions (button view)

prioux commented 4 years ago

Wow, quite a large set of changes @candicecz !

natacha-beck commented 4 years ago

Issues closed as of Apr 20th

Enter NeuroHub bugs/limitations below as a checklist. Checkboxes are created with dash, space, square bracket, space, square bracket, space (- [ ] Text).

[x] (Pierre) No error message is shown when the user has invalid username or password in the signin page. Wasn't there a place for flash messages there before?
[x] (Pierre) (Minor, about the source code) File views/nh_projects/_form_for.html.erb should be renamed. Why is there a '_for' in there, it's not like the Rails method...
[x] (Pierre) Why does My Account show the Zenodo sandbox token but not the official one?
[x] (Natacha) BUG: the search function is totally inefficient; if someone search for something that returns lots of results, all the result objects are built before being limited to 20. This occurs at this line: @files = @results[:files][0,@limit] which is an array operation instead of an active record limit. E.g. in the production DB if an admin search for 'a', the code will reconstruct 286,000 objects before selecting the first 20 and discarding the rest. (I fixed this -- PR)
[x] (Natacha) Search crash on my dev environment: no such method keep_if in neurohub_portal_controller line 94. (I fixed this -- PR)

MontrealSergiy commented 4 years ago

@prioux @natacha-beck @candicecz I recall on previous meeting we were suggested to add more items to neurohub news. Not sure who was assigned. Perhaps we can add something (may be check first with diana, samir or/and JB ) "New features added - upload, connecting folders on users personal or supercomputer disc space with ssh, paging and search. Neurohub is feature complete! After extensive testing and optimization Neurohub will be open for organization wide use.

MontrealSergiy commented 4 years ago

@nbeck How task search work? if I (sboroday) search for word 'file' I get bunch of task yet trying searching by a task name fragment (niak) brings nothing. Well actually looks like same with cbrain, so since nobody complained probably not issue

MontrealSergiy commented 4 years ago

@prioux Not sure why "Pagination defaults to 20 even if there are less than 20 items." is a bug, but to keep everybody happy, may be I or @candicecz can hide pagination controls from small lists ?

candicecz commented 4 years ago

Issues closed as of Apr 22nd

[x] (Candice) With the new licensing stuff, I added a link to 'View Licenses' at the top of project, but I put it such that only the project's maintainer can see the link and click on it. The link should work for any members of the project, though, so feel free to put it elsewhere.
[x] In my account page, it will be useful to have a link to CBRAIN for all the User tasks and files.
[x] (Candice) When we have pagination it will be useful to know the total number if items (like we have in CBRAIN)
[x] On nh_projects index page we sometimes have the name of the maintainer in blue or in grey but both are link.
[x] UI issue in index of project, I am not able to see anymore the number of items setting (repored by Natacha)

MontrealSergiy commented 4 years ago

regarding bug "Acces to index of files of a Public project " - exactly the same on private projects file index might differ as well. yet unavailable files cannot be downloaded, and error message is displayed if user click on it. @natacha-beck we just discussed it yesterday

MontrealSergiy commented 4 years ago

@prioux @xlecours who should be able to add storage/dp to neurohub projects? just any contributor (as it is now) or only editors?

prioux commented 4 years ago

@MontrealSergiy only the creator or the editors

prioux commented 4 years ago

Well, maybe not... ?

natacha-beck commented 4 years ago

For the following point:

Acces to index of files of a Public project do not ...

@MontrealSergiy after discussion with @prioux everything is ok. We know why the list is different and that is fine like that. In NH every files of the project are shown and in CBRAIN only the one on available DataProvider are display on the index page.

aces / cbrain

NeuroHub bugs checklist #921