search

acfoltzer / nbt

A parser/serializer for Minecraft's Named Binary Tag (NBT) data format.
BSD 3-Clause "New" or "Revised" License
22 stars 8 forks source link

Fixes all the things :) #5

Closed ghost closed 11 years ago

ghost commented 11 years ago

Hi!

I made a whole bunch of changes to the nbt library. It completely breaks the API as you know it, but it should be more performant (Text instead of String, Array Int32 instead of []) and usable (all Maybe String fields are gone, making it a bit easier to parse NBT-encoded structures).

I hope you find my changes useful. If you plan to merge, make sure to revert the changes I made to README.md.

Kind regards,

Stijn

acfoltzer commented 11 years ago

Hi Stijn,

Thanks a ton for this! These are a bunch of changes I've been meaning to make.

I'm really busy presently, but will try to get this merged ASAP.

Adam

On Fri, Dec 14, 2012 at 7:18 AM, Stijn van Drongelen < notifications@github.com> wrote:

Hi!

I made a whole bunch of changes to the nbt library. It completely breaks the API as you know it, but it should be more performant (Text instead of String, Array Int32 instead of []) and usable (all Maybe String fields are gone, making it a bit easier to parse NBT-encoded structures).

I hope you find my changes useful. If you plan to merge, make sure to revert the changes I made to README.md.

Kind regards,

Stijn

You can merge this Pull Request by running:

git pull https://github.com/Tinctorius/nbt master

Or view, comment on, or merge it at:

https://github.com/acfoltzer/nbt/pull/5 Commit Summary

  • add basic support for IntArrays
  • update test suite to use cabal and replace error with fail
  • update cabal file description and tested-with
  • added support for new Int_Array tag
  • changed ByteArray representation to an array of bytes
  • Added support for TAG_Int_Array.
  • corrected pointer to repository
  • Merge branch 'Branch_0.3'
  • Remove explicit payload size from data structure.
  • ListTag now carries an array.
  • Eradicated EndTag.
  • Use fail instead of error in the Get monad.
  • Merge commit '5188cd501f4696c58e1c786f48a49957faec6277'
  • Removed length field of TagString.
  • Merge branch 'Branch_d2043bcdbf3f1f161daba82185bbf1bcafb116d6'
  • NBT utilities: typeOf and nameOf
  • Toggle .travis.yml
  • Toggle .travis.yml
  • drop version constraints on test-framework* packages
  • sigh... Travis-ci has case-sensitive URLs
  • Disabled Travis-CI's e-mail notifications.
  • Removed EndType.
  • Moved names of tags to compound tags.
  • Turned String field of StringTag into Text.

File Changes

  • M .travis.yml (2)
  • M README.md (4)
  • M nbt.cabal (66)
  • M src/Data/NBT.hs (284)
  • A test/RoundTrip.hs (87)
  • D test/Tests.hs (81)
  • D test/nbt-tests.cabal (23)

Patch Links

acfoltzer commented 11 years ago

Hi Stijn,

I'm merging this now; thanks for the reminder. Would it be okay to mention you in the cabal Authors section?

On Wed, Mar 13, 2013 at 11:04 AM, Stijn van Drongelen < notifications@github.com> wrote:

Bump? ^_^

— Reply to this email directly or view it on GitHubhttps://github.com/acfoltzer/nbt/pull/5#issuecomment-14858389 .

ghost commented 11 years ago

Certainly :) You can mention me as Stijn van Drongelen <rhymoid@gmail.com> (if you need that e-mail address).