[fix] rviz crash after capture

acfr / cam_lidar_calibration

(ITSC 2021) Optimising the selection of samples for robust lidar camera calibration. This package estimates the calibration parameters from camera to lidar frame.

Apache License 2.0

457 stars 107 forks source link

[fix] rviz crash after capture #33

Closed juliangaal closed 1 year ago

juliangaal commented 1 year ago

This PR introduces two changes

fix opencv headers
Fix rviz crash in endless loop of service callback. Adapt switch case to skip capturing if a captured frame is currently captured
flag can be accessed from multiple threads. Made threadsafe

jclinton830 commented 1 year ago

@juliangaal which ROS version are you working with?

juliangaal commented 1 year ago

Noetic.

I realize that changing the OpenCV version isn't strictly necessary, but officially Ubuntu 18.04 doesn't have any support and OpenCV 4 is installed alongside noetic

jclinton830 commented 1 year ago

Noetic.

I realize that changing the OpenCV version isn't strictly necessary, but officially Ubuntu 18.04 doesn't have any support and OpenCV 4 is installed alongside noetic

Fair enough. If your changes are making it work successfully for Noetic maybe the best approach is to publish this as a different branch. We can call this branch Noetic.

jclinton830 commented 1 year ago

@juliangaal I just made a new branch called noetic. Can you make a PR to merge your changes to this new branch?

juliangaal commented 1 year ago

Sure, I'll do that first thing Monday morning. We should ask the developer stuck with #37 to test the branch after the merge.

jclinton830 commented 1 year ago

@juliangaal Yes that is the plan. I think it would be easier for her to test once these changes are available as a branch.

juliangaal commented 1 year ago

Had a couple minutes, see #38