search

acfr / comma

generic c++ libraries
Other
27 stars 16 forks source link

input_stream::is_binary() and output_stream::is_binary() do not compile #41

Closed akas9185 closed 10 years ago

akas9185 commented 10 years ago

I think it has to do with the new "explicit conversion operator bool" feature. Maybe it has to be staticcast(binary) instead?

vlaskine commented 10 years ago

Could you please be more specific? Comma compiles with no problem on my machine.

akas9185 commented 10 years ago

comma compiles fine but using input_stream::is_binary() does not compile. The function is defined in the header file stream.h

From: vlaskine notifications@github.com Sent: 22 July 2014 11:41 To: acfr/comma Cc: akas9185 Subject: Re: [comma] input_stream::is_binary() and output_stream::is_binary() do not compile (#41)

Could you please be more specific? Comma compiles with no problem on my machine.

Reply to this email directly or view it on GitHubhttps://github.com/acfr/comma/issues/41#issuecomment-49688602.

vlaskine commented 10 years ago

i wrote a test that calls input_stream::is_binary(); it happily compiles and passes

could you please give more details: compiler output, code snippets - anything?

vlaskine commented 10 years ago

please reopen the ticket, the compilation still is broken, or better come and talk to me